Fb triag 1493/clean up empty feature flag #7822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…projects_counts_api_short that is not present in the codebase
…pport_vertex_ai_support_short that is not present in the codebase
luarmr
requested review from
hlomzik,
Gondragos and
nick-skriabin
as code owners
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #7822 +/- ##
========================================
Coverage 78.48% 78.49%
========================================
Files 206 206
Lines 16504 16504
========================================
+ Hits 12953 12954 +1
+ Misses 3551 3550 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nass600
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Archive a list of FF, here are the links.
Some of them has reference in the code that do not affect logic and that was consider empty flas and also removed:
List:
ff_front_1170_outliner_030222_short
https://github.com/search?q=org:HumanSignal+-is:archived+ff_front_1170_outliner_030222_short&type=code
ff_front_dev_1658_notification_center_170222_short
https://github.com/search?q=org:HumanSignal+-is:archived+ff_front_dev_1658_notification_center_170222_short&type=code
https://github.com/search?q=org:HumanSignal+-is:archived+FF_DEV_1658&type=code
fflag_feat_all_lsdv_4915_async_task_import_13042023_short
https://github.com/search?q=org:HumanSignal+-is:archived+fflag_feat_all_lsdv_4915_async_task_import_13042023_short&type=code https://github.com/search?q=org:HumanSignal+-is:archived+FF_LSDV_4915&type=code
fflag_feat_front_lops_86_datasets_storage_edit_short
https://github.com/search?q=org:HumanSignal+-is:archived+fflag_feat_front_lops_86_datasets_storage_edit_short&type=code
fflag_feat_all_optic_1181_membership_performance
https://github.com/search?q=org:HumanSignal+-is:archived+fflag_feat_all_optic_1181_membership_performance&type=code
fflag_feat_front_optic_1351_use_new_projects_counts_api_short
https://github.com/search?q=org:HumanSignal+-is:archived+fflag_feat_front_optic_1351_use_new_projects_counts_api_short&type=code
Only in stale ff
fflag_feat_front_optic_1417_improve_project_list_cache_short
https://github.com/search?q=org:HumanSignal+-is:archived+fflag_feat_front_optic_1417_improve_project_list_cache_short&type=code
fflag_feat_dia_1528_gemini_models_support_vertex_ai_support_short
https://github.com/search?q=org:HumanSignal+-is:archived+fflag_feat_dia_1528_gemini_models_support_vertex_ai_support_short&type=code
fflag_feat_back_optic_1157_set_ground_truths_action
https://github.com/search?q=org:HumanSignal+-is:archived+fflag_feat_back_optic_1157_set_ground_truths_action&type=code